Address PR Review Comments (oh-my-opencode)

Requires: oh-my-opencode with hephaestus agent configured.

Fetch all open PR review comments, triage them by criticality, fix every issue (one commit per fix, delegated to hephaestus), push, then reply in-thread to each comment with what was done. Fix everything — including low priority items.

Generic version: See address-pr-comments for a version that works with any coding agent.

⚠️ Agent Discipline — Read Before Starting

These rules govern every subagent call in this skill. They override your instincts.

1. You are a blocker, not a poller. All task() calls in this skill use run_in_background=false. This means they are synchronous — the runtime blocks until the subagent responds. You do not poll. You do not call background_output. You do not set timers. You just wait.

2. Silence is not stuck. An agent that hasn't responded yet is working. Agents can take 2–10 minutes on complex tasks. "It's taking a while" is not a signal to act.

3. You have exactly one job while waiting: nothing. Do not read files. Do not grep. Do not "prepare" for the next step. Wait. Your context window is not a resource to fill — it is a resource to preserve.

4. Cancellation is forbidden except on user instruction. You may not cancel Hephaestus for any reason you invent. Only the user can abort a running agent.

5. If an agent genuinely errors or times out (system-level failure): Stop. Tell the user what happened and which step failed. Do not attempt the work yourself. Do not retry without being asked.

Trigger

Use this skill when the user says any of:

"address PR comments", "fix review comments", "handle PR feedback"
"respond to PR review", "address the review"

Arguments

[pr_number] (optional) — PR number to address. If omitted, uses the PR associated with the current branch.

Step 0 — Identify the PR

If pr_number was provided, use it directly. Otherwise:

# Get the PR for the current branch
gh pr view --json number,title,headRefName

Also fetch repo context needed for API calls:

gh repo view --json owner,name --jq '"\(.owner.login)/\(.name)"'

Store: {owner}, {repo}, {pr_number}.

Step 1 — Fetch All Review Comments

gh api /repos/{owner}/{repo}/pulls/{pr_number}/comments \
  --jq '.[] | select(.in_reply_to_id == null) | {id: .id, path: .path, line: .line, body: .body, diff_hunk: .diff_hunk}'

Why select(.in_reply_to_id == null)? This filters to root comments only (the original thread starters). You always reply to the root, not to nested replies.

Also fetch the PR description and diff for context:

gh pr view {pr_number} --json title,body,commits
git diff origin/main...HEAD

Step 2 — Triage by Criticality

Group each root comment into one of:

Priority	Criteria
Critical	Security issue, data loss risk, broken functionality, API contract violation
High	Logic bug, missing error handling, performance issue, type safety violation
Medium	Code clarity, naming, missing tests, refactoring suggestion
Low	Style, formatting, minor nitpicks, optional improvements

Print a triage table before starting any fixes:

PR #N — Review Comment Triage
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
  Critical:  X comments
  High:      Y comments
  Medium:    Z comments
  Low:       W comments
  Total:     T comments (all will be fixed)

Step 3 — Fix Every Comment

Process in priority order: Critical → High → Medium → Low.

For each comment:

Code changes (refactoring, bug fixes, logic changes, new code) → delegate to hephaestus via task():

task(subagent_type="hephaestus", run_in_background=false, prompt="
  TASK: Fix the following PR review comment.

  COMMENT: {comment_body}
  FILE: {path}
  LINE: {line}
  DIFF CONTEXT:
  {diff_hunk}

  FEATURE CONTEXT: {brief description of what the PR is building}

  Fix exactly what the comment asks. Do not refactor unrelated code.
  After fixing, commit with: fix(pr-{pr_number}): {short description} [{priority}]
")

Simple fixes (typos, import reordering, whitespace, single-line changes) → apply directly with edit tools, then commit:

git add <affected files>
git commit -m "fix(pr-{pr_number}): {short description} [{priority}]"

One commit per comment. No batching.

If a comment is unclear: make a reasonable interpretation, note it in the reply.

If a fix is genuinely impossible (e.g. comment refers to removed code, contradicts another requirement): skip the fix, but still reply explaining why.

Commit format examples:

fix(pr-42): add null check before accessing user.profile [critical]
fix(pr-42): rename variable for clarity [low]
fix(pr-42): extract magic number to named constant [medium]

Step 4 — Push

git push

Step 5 — Reply to Each Comment Thread

For every root comment addressed in Step 3, post a reply in the same thread using the /replies endpoint:

gh api \
  -X POST \
  -H "Accept: application/vnd.github+json" \
  /repos/{owner}/{repo}/pulls/{pr_number}/comments/{comment_id}/replies \
  -f body="{reply_body}"

Reply format:

Fixed in {commit_sha} — {1-2 sentence description of what was changed and why}.

For skipped comments:

Not fixed — {clear explanation of why this cannot or should not be changed}.

CRITICAL: Use the /replies endpoint with the root comment's id. Do NOT use gh pr comment or gh issue comment — those create standalone PR timeline comments, not threaded replies.

Step 6 — Summary

Print a completion summary:

✅ PR #N review comments addressed.
   Fixed:    X commits pushed
   Skipped:  Y (see replies for reasons)

Commits:
  abc1234 fix(pr-N): ...
  def5678 fix(pr-N): ...

Agent Assignment

Task type	Handler
Code changes, refactoring, logic fixes	`hephaestus` via `task()`
Simple fixes (typos, formatting, imports)	Direct edit tools
Architecture / design questions	Consult `oracle` or ask user

Anti-Patterns

NEVER:

Batch multiple fixes into one commit — one commit per comment
Skip low-priority comments — fix everything unless genuinely impossible
Use gh pr comment or gh issue comment to reply — these add standalone comments, not threaded replies
Reply before pushing — always push first so the commit SHA is valid in the reply
Pass vague context to hephaestus — include the full diff_hunk, file path, line number, and feature description
Cancel Hephaestus mid-flight because you found something in the meantime — if you launched it, you collect it; "I have enough context" is never a valid cancellation reason

address-pr-comments-omo