spec-finish
Spec Finish
Post-implementation workflow: validate → review → stack commits → prepare PR.
Prerequisites
Before starting, verify:
- All implementation tasks complete
- Working directory is clean (committed or staged)
- Tests pass
If not complete → go back to spec-implement.
Step 1: Validate
Run validation checks.
Test Suite
npm test
# or
pytest
# or
cargo test
Type Check
npm run typecheck
# or
python -m mypy
# or
cargo check
Lint
npm run lint
# or
ruff check .
# or
cargo clippy
Build
npm run build
# or
go build ./...
If any fail: Return to spec-implement to fix.
If all pass: Proceed.
Step 2: Review
Use the Skill tool to invoke code-review skill for comprehensive code review.
What to Review
- All changed files since feature branch
- Test coverage
- Documentation updates
- No debug code left
If code-review finds issues
- Fix or note for follow-up
- Re-validate
Step 3: Stack Commits
Use the Skill tool to invoke code-stacked-commit skill.
Workflow
- Review current stack:
gt stack - Ensure commits are organized logically
- Restack if needed:
gt branch restack - Ensure each commit is clean and functional
Commit Guidelines
- Each commit should pass tests
- Use conventional commit format
- Meaningful commit messages
Step 4: Update Documentation
Optional - use code-docs skill if needed.
Check for Updates
- README changes needed?
- API documentation updated?
- Changelog updated?
If documentation needed
- Load code-docs
- Update relevant docs
- Commit with docs
Step 5: Prepare for PR
Verify
- All tests passing
- All reviews complete
- Documentation updated
- Commits stacked properly
Summary for Human
## Completion Summary
**Feature:** [name]
**Tests:** [passed/failed]
**Type Check:** [passed/failed]
**Lint:** [passed/failed]
**Commits:** [N commits in stack]
**Ready for PR:** [yes/no]
Handoff
"Implementation complete. [N] commits stacked. Ready for [submit/open PR]."
Integration
This skill orchestrates other skills:
- Invokes code-review for quality check
- Invokes code-stacked-commit for commit management
- Invokes code-docs if documentation needs updates
When NOT to Use
- If implementation still in progress → use spec-implement
- If tests failing → go back to spec-implement
- If review found blocking issues → go back to spec-implement
More from martinffx/atelier
typescript:drizzle-orm
Type-safe SQL with Drizzle ORM in TypeScript. Use when defining database schemas, writing queries, setting up relations, running migrations, or working with PostgreSQL/MySQL/SQLite/Cloudflare D1/Durable Objects data layers.
14oracle:thinkdeep
Extended reasoning analysis using sequential thinking. Use for deep exploration, comprehensive analysis, complex decisions, or when you need fresh perspectives on difficult problems.
10code:review
Multi-agent code review with parallel specialized reviewers, architecture validation, and challenge validation. Use `rq` to request a review of diffs (defaults to main branch), `rs` to respond to PR feedback. Triggers on "review this", "review my code", "code review", "check for bugs", "audit this", when examining PRs, pull requests, branches, or diffs. Supports line-by-line PR comments via gfreview with severity prefixes (Blocker/Issue/Suggestion/Nit). Always asks user before applying fixes or posting responses.
10code:stacked-commit
Manage stacked commits using Graphite. Use when the user wants to create multiple stacked commits, manage a commit stack, sync with remote, or submit PRs from a stack. Triggers on "stacked", "stack", "gt ", "graphite", or when working with multiple related commits.
9typescript-drizzle-orm
Type-safe SQL with Drizzle ORM in TypeScript. Use when defining database schemas, writing queries, setting up relations, running migrations, or working with PostgreSQL/MySQL/SQLite/Cloudflare D1/Durable Objects data layers.
9spec:implement
>
9