Code Review

Review the proposed changes as a senior maintainer. Focus on actionable defects introduced by the changes, especially correctness issues, regressions, and changes that are not necessary for the stated goal.

Establish the Review Scope

Before reviewing:

1. Determine the intended change from the request, pull request description, linked issue, and maintainer comments.
2. Identify the complete diff against the appropriate base.
3. Account for every changed file and subsystem.

Do not infer the purpose solely from the implementation. If the intended behavior is unclear, state the assumption used for the review.

Review the Changes

Trace the changed behavior through its callers, dependencies, and tests. Check for: