Perses Code Review

Review code changes in Perses repositories for domain-specific patterns, API conventions, plugin system compliance, and dashboard correctness. This skill enforces Perses-specific invariants across Go backend, React frontend, CUE schemas, and dashboard definitions — a passing golangci-lint or generic code review does not mean the code follows Perses conventions.

Instructions

Phase 1: CLASSIFY

Goal: Determine the review domains for this PR so you can apply the right checks to each file type.

1. List all changed files and categorize:

   • Go backend (.go) — files under /cmd, /pkg, /internal
   • React frontend (.ts, .tsx) — files in @perses-dev/* packages
   • CUE schemas (.cue)
   • Dashboard definitions (.json, .yaml with kind: Dashboard)

2. Identify cross-domain changes, because schema and plugin changes must stay synchronized. When a PR touches both CUE schemas and plugin code, the schema changes must match the plugin's expected input/output types — a plugin PR that adds configuration options without updating the corresponding CUE schema leaves the schema registry out of sync, causing UI options to fail CUE validation or the backend to accept options the UI cannot expose. Flag these for paired review.

3. Flag dashboard definition files for percli lint in Phase 2. Dashboard JSON can be structurally valid but semantically broken (invalid panel references, wrong plugin kinds, malformed variable expressions). Manual review catches some of these; percli lint catches all of them deterministically.