pr-49-review
PR #49 Review
Quick start
Use this checklist to review PR #49:
- Gather PR metadata and file list:
gh pr view 49 --json title,body,files,commits,additions,deletions
- Inspect the diff:
gh pr diff 49
- Identify risks (security, operational, regressions) and missing tests.
- Provide a concise review with severity ordering.
Review focus
- Security: default credentials, anonymous access, exposed ports, secrets in logs.
- Operations: logging paths, rotation, scheduler installs, cleanup/uninstall.
- Correctness: healthcheck logic, log parsing, alert thresholds.
- Repo hygiene: generated logs or artifacts committed, ignores updated.
- Docs: accurate commands, prerequisites, and troubleshooting steps.
Output format
Provide feedback in this exact order:
- Critical issues
- Warnings
- Suggestions
- Summary of changes
- Test plan
Keep the feedback specific to PR #49 and reference files by path.
More from sayujks0071/antidhan
risk-management
Implement and review risk controls, position sizing, portfolio heat limits, stop losses, and risk monitoring. Use when implementing risk management, reviewing risk controls, calculating position sizes, or analyzing portfolio risk exposure.
7backtesting-analysis
Run backtests, analyze strategy performance, compare strategies, and generate ranking reports. Use when backtesting strategies, analyzing performance metrics, comparing strategy variants, or generating backtest reports.
6strategy-prioritization
Analyze, rank, and prioritize trading strategies using multi-factor scoring. Use when creating prioritization plans, ranking strategies, analyzing strategy portfolios, comparing strategy performance, or making strategy selection decisions.
6integration-patterns
OpenAlgo-AITRAPP integration patterns, adapters, mocks, and strategy conversion. Use when integrating strategies with AITRAPP backtest engine, creating adapters, mocking OpenAlgo APIs, or converting strategies between systems.
6symbol-datestamp-correction
Correct NSE and MCX symbol formats and datestamp conversions for OpenAlgo. Standardizes expiry dates to DD-MMM-YY format, constructs proper futures/options symbols, and validates symbol structure. Use when processing broker data, fixing symbol format errors, converting dates, or validating trading symbols.
6history-payload-validator
Validate and fix OpenAlgo history API payloads before strategy runs. Use when /api/v1/history returns 400/404, symbols are missing, intervals are invalid, or master contracts need refreshing.
6