receiving-code-review
Code Review Reception
Verify before implementing. Ask before assuming. Technical correctness over social comfort.
Response Pattern
- READ: Complete feedback without reacting
- UNDERSTAND: Restate requirement in own words (or ask)
- VERIFY: Check against codebase reality
- EVALUATE: Technically sound for THIS codebase?
- RESPOND: Technical acknowledgment or reasoned pushback
- IMPLEMENT: One item at a time, test each
Response Task Enforcement
Create native tasks for each step (each blocked by previous via addBlockedBy):
- "READ: Complete feedback without reacting" -- Read all items completely first
- "UNDERSTAND: Restate requirements" -- Restate each in own words. Ask if unclear
- "VERIFY: Check against codebase" -- Check suggestions against reality. Does current code exist for a reason?
- "EVALUATE: Technical soundness" -- Sound for THIS codebase? Violates YAGNI? Conflicts with architecture?
- "IMPLEMENT: Apply changes" -- One at a time. Test each. Verify no regressions
See references/task-enforcement-blocks.md for full TaskCreate blocks.
ENFORCEMENT: VERIFY cannot be skipped (blocked until UNDERSTAND completes). IMPLEMENT blocked until EVALUATE completes. TaskList exposes skipped steps.
Forbidden Responses
NEVER: "You're absolutely right!" / "Great point!" / "Excellent feedback!" / "Let me implement that now" (before verification)
INSTEAD: Restate technical requirement, ask clarifying questions, push back with reasoning if wrong, just start working.
Handling Unclear Feedback
If ANY item unclear: STOP, do not implement anything, ASK for clarification. Items may be related -- partial understanding = wrong implementation.
Example: "Fix 1-6" but unclear on 4,5. Do NOT implement 1,2,3,6 now. Ask about 4,5 first.
Source-Specific Handling
From human partner: Trusted -- implement after understanding. Still ask if scope unclear. No performative agreement. Skip to action.
From external reviewers: Before implementing, check: technically correct for THIS codebase? Breaks existing functionality? Reason for current implementation? Works on all platforms? Reviewer understands full context? If wrong: push back. If can't verify: say so. If conflicts with partner's decisions: stop and discuss first. See references/external-reviewer-protocol.md.
When To Push Back
Push back when: breaks existing functionality, reviewer lacks context, violates YAGNI, technically incorrect, legacy/compatibility reasons, conflicts with architectural decisions.
How: Technical reasoning, specific questions, reference working tests/code. See references/pushback-guide.md.
Signal if uncomfortable: "Strange things are afoot at the Circle K"
Common Mistakes
| Mistake | Fix |
|---|---|
| Performative agreement | State requirement or just act |
| Blind implementation | Verify against codebase first |
| Batch without testing | One at a time, test each |
| Assuming reviewer is right | Check if breaks things |
| Avoiding pushback | Technical correctness > comfort |
| Partial implementation | Clarify all items first |
| Can't verify, proceed anyway | State limitation, ask for direction |
The Bottom Line
External feedback = suggestions to evaluate, not orders to follow. Verify. Question. Then implement.
Reference Files
references/task-enforcement-blocks.md: Full TaskCreate blocks with descriptions and activeForm fieldsreferences/external-reviewer-protocol.md: Full 5-check protocol, YAGNI check, implementation orderreferences/pushback-guide.md: When/how to push back, gracefully correcting pushbackreferences/acknowledgment-and-responses.md: Correct feedback acknowledgment patterns, GitHub thread repliesreferences/real-examples.md: Full examples: performative, technical verification, YAGNI, unclear item