typing-exclusion-worker
Typing Exclusion Worker
Purpose
Execute one assigned typing batch safely and predictably:
- remove only assigned modules from mypy exclusions,
- fix surfaced typing issues in scope,
- run required checks,
- return a consistent summary for the manager/orchestrator.
Inputs Required
Before starting, confirm these inputs exist in the task prompt:
- worktree/branch name,
- exact module list to remove from exclusion,
- ownership/domain boundary,
- expected validation commands (if customized).
If any are missing, ask for them before editing.
Scope Rules (Hard Constraints)
- Only remove assigned module entries from the mypy exclusion list in
pyproject.toml. - Keep code changes in assigned scope unless a direct dependency is required to pass typing/tests.
- Do not expand to cross-team modules unless explicitly approved by the manager.
- Avoid blanket
# type: ignore; if unavoidable, use narrowignore[code]with a short reason.
Execution Workflow
-
Apply exclusion change
- Remove assigned modules from the exclusion override in
pyproject.toml.
- Remove assigned modules from the exclusion override in
-
Run mypy on assigned scope
- Prefer targeted paths first for fast feedback.
- Fix errors using explicit typing patterns (
isinstancenarrowing, accurate return types, typed class attrs, relation-safe model access).
-
Run tests for touched area
- Execute targeted pytest for modified modules/tests.
- Fix regressions before continuing.
-
Run pre-commit on changed files
- Run
pre-commit run --files <changed files>. - If hooks auto-fix files, rerun until clean.
- Run
-
Final verification
- Re-run targeted mypy and tests after final edits.
- Ensure no unrelated files were changed.
Python Typing Best Practices
- Prefer precise types over
Any. - Use type narrowing on unions before attribute access.
- Keep method overrides signature-compatible with base classes.
- Annotate class attributes in tests/helpers when inference is weak.
- Use relation objects (
obj.related) when stubs do not expose raw*_idattributes.
Required Output Template
Return this exact structure at the end of each batch:
## Batch Summary
- Branch/worktree: `<name>`
- Ownership/domain: `<team-or-domain>`
### Modules Removed From Exclusion
- `<module.path.one>`
- `<module.path.two>`
### Files Changed
- `<path>`
- `<path>`
### Key Typing Fixes
- `<short rationale + fix>`
- `<short rationale + fix>`
### Validation
- `mypy`: `<pass/fail + scope>`
- `pre-commit --files`: `<pass/fail>`
- `pytest`: `<pass/fail + scope>`
### Notes
- Remaining blockers: `<none or details>`
- Any new ignore entries: `<none or file + ignore code + reason>`
Stop Conditions (Escalate to Manager)
Stop and report instead of widening scope when:
- fixes require touching another team/domain,
- exclusion conflicts in
pyproject.tomlcannot be resolved safely, - error volume indicates batch is too large and should be split.
More from getsentry/skills
security-review
Security code review for vulnerabilities. Use when asked to "security review", "find vulnerabilities", "check for security issues", "audit security", "OWASP review", or review code for injection, XSS, authentication, authorization, cryptography issues. Provides systematic review with confidence-based reporting.
4.8Kcode-simplifier
Simplifies and refines code for clarity, consistency, and maintainability while preserving all functionality. Use when asked to "simplify code", "clean up code", "refactor for clarity", "improve readability", or review recently modified code for elegance. Focuses on project-specific best practices.
4.1Kfind-bugs
Find bugs, security vulnerabilities, and code quality issues in local branch changes. Use when asked to review changes, find bugs, security review, or audit code on the current branch.
2.1Kagents-md
Creates and maintains concise AGENTS.md and CLAUDE.md project instruction files. Use when asked to create AGENTS.md, update AGENTS.md, maintain agent docs, set up CLAUDE.md, document repository agent conventions, or keep coding-agent instructions minimal and reference-backed.
2.0Kcode-review
Perform code reviews following Sentry engineering practices. Use when reviewing pull requests, examining code changes, or providing feedback on code quality. Covers security, performance, testing, and design review.
2.0Kcommit
ALWAYS use this skill when committing code changes — never commit directly without it. Creates commits following Sentry conventions with proper conventional commit format and issue references. Trigger on any commit, git commit, save changes, or commit message task.
1.9K